chore(engine-core): Improve binary search logic #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's merge this after the release, as this is critical logic |
|
@williamluke4 can you give some context what the improvements are for? |
timsuchanek
reviewed
Oct 27, 2020
timsuchanek
reviewed
Oct 27, 2020
timsuchanek
reviewed
Oct 27, 2020
Jolg42
added a commit
that referenced
this pull request
Oct 29, 2020
* master: fix(deps): update engines to v2.11.0-7-2034ce0e038ece25b48b5180b41ccb48d2c3344f (#4091) chore(deps): update devdependencies (non-major) (#4084) fix(deps): update engines to v2.11.0-3-6fafbb461b7e0c140280a7794ed19a4f7035f577 (#4080) chore(engine-core): Improve binary search logic (#4054) chore(deps): update dependency esbuild to v0.7.22 (#4078) fix(deps): update engines to v2.11.0-2-6b72297958d424b0e0a0829a95b76ccc966132fd (#4073)
Jolg42
added a commit
that referenced
this pull request
Oct 29, 2020
* master: fix(deps): update engines to v2.11.0-7-2034ce0e038ece25b48b5180b41ccb48d2c3344f (#4091) chore(deps): update devdependencies (non-major) (#4084) fix(deps): update engines to v2.11.0-3-6fafbb461b7e0c140280a7794ed19a4f7035f577 (#4080) chore(engine-core): Improve binary search logic (#4054) chore(deps): update dependency esbuild to v0.7.22 (#4078) fix(deps): update engines to v2.11.0-2-6b72297958d424b0e0a0829a95b76ccc966132fd (#4073)
Jolg42
added a commit
that referenced
this pull request
Oct 29, 2020
* master: fix(deps): update engines to v2.11.0-7-2034ce0e038ece25b48b5180b41ccb48d2c3344f (#4091) chore(deps): update devdependencies (non-major) (#4084) fix(deps): update engines to v2.11.0-3-6fafbb461b7e0c140280a7794ed19a4f7035f577 (#4080) chore(engine-core): Improve binary search logic (#4054) chore(deps): update dependency esbuild to v0.7.22 (#4078) fix(deps): update engines to v2.11.0-2-6b72297958d424b0e0a0829a95b76ccc966132fd (#4073) chore(deps): update devdependencies (non-major) (#4065) chore: update engines pkg (#4069) chore: test renovate config [skip ci] chore: test renovate config [skip ci] chore: test renovate config [skip ci] chore(deps): update devdependencies (non-major) (#3846) # Conflicts: # src/packages/migrate/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is:
contents of the last search space (Current)